feat(M4): Reusable code abstractions and dead-code removal

pi-package/skills/web-automation/scripts/scan-local-app.ts

@@ -3,7 +3,8 @@
 
 import { mkdirSync, writeFileSync } from 'fs';
 import { dirname, resolve } from 'path';
-import { getPage } from './browse.js';
+import type { Page } from 'playwright-core';
+import { getPage } from './lib/browser.js';
 
 type NavResult = {
   requestedUrl: string;
@@ -40,30 +41,34 @@ function getRoutes(baseUrl: string): string[] {
   return [baseUrl];
 }
 
-async function gotoWithStatus(page: any, url: string): Promise<NavResult> {
+type GotoError = { error: unknown };
+
+async function gotoWithStatus(page: Page, url: string): Promise<NavResult> {
   const response = await page
     .goto(url, { waitUntil: 'domcontentloaded', timeout: 60000 })
-    .catch((error: unknown) => ({ error }));
+    .catch((error: unknown): GotoError => ({ error }));
 
-  if (response?.error) {
+  if (response !== null && response !== undefined && 'error' in response) {
+    const gotoError = response as GotoError;
     return {
       requestedUrl: url,
       url: page.url(),
       status: null,
       title: await page.title().catch(() => ''),
-      error: String(response.error),
+      error: String(gotoError.error),
     };
   }
 
+  const httpResponse = response as Awaited<ReturnType<Page['goto']>>;
   return {
     requestedUrl: url,
     url: page.url(),
-    status: response ? response.status() : null,
+    status: httpResponse ? httpResponse.status() : null,
     title: await page.title().catch(() => ''),
   };
 }
 
-async function textOrNull(page: any, selector: string): Promise<string | null> {
+async function textOrNull(page: Page, selector: string): Promise<string | null> {
   const locator = page.locator(selector).first();
   try {
     if ((await locator.count()) === 0) return null;
@@ -74,7 +79,7 @@ async function textOrNull(page: any, selector: string): Promise<string | null> {
   }
 }
 
-async function loginIfConfigured(page: any, baseUrl: string, lines: string[]) {
+async function loginIfConfigured(page: Page, baseUrl: string, lines: string[]) {
   const loginPath = env('SCAN_LOGIN_PATH');
   const username = env('SCAN_USERNAME') ?? env('CLOAKBROWSER_USERNAME');
   const password = env('SCAN_PASSWORD') ?? env('CLOAKBROWSER_PASSWORD');
@@ -110,7 +115,7 @@ async function loginIfConfigured(page: any, baseUrl: string, lines: string[]) {
   lines.push('');
 }
 
-async function checkRoutes(page: any, baseUrl: string, lines: string[]) {
+async function checkRoutes(page: Page, baseUrl: string, lines: string[]) {
   const routes = getRoutes(baseUrl);
   const routeChecks: RouteCheck[] = [];