feat(M3): Shared-source generator for agent variants

2026-05-03 21:09:22 -05:00
parent be993429c1
commit 86ad783f82
339 changed files with 20650 additions and 145 deletions
@@ -293,6 +293,59 @@ changes the baseline status of a check.*

 ---

+## Post-M3 state
+
+Captured: 2026-05-03 · Platform: macOS 15 (arm64) · Node 22.14.0 · pnpm 10.18.1
+
+M3 resolved all remaining pre-existing `lint` violations (2 ESLint errors and
+7 shellcheck findings).  `verify:generated` is now a real implementation
+(was a stub in M2).
+
+### `pnpm run check` aggregate (post-M3)
+
+```text
+PASS  lint             (was FAIL in M1/M2; pre-existing violations fixed in M3)
+PASS  typecheck
+PASS  test
+PASS  verify:pi
+PASS  verify:reviewers
+PASS  verify:docs
+PASS  verify:generated (was stub in M2; real implementation in M3)
+```
+
+Overall exit: **0** — all checks green for the first time.
+
+### What changed in M3
+
+- `scripts/generate-skills.mjs` added (generator for all 31 agent-variant roots).
+- `scripts/verify-generated.mjs` added (drift detector).
+- Canonical source directories created: `skills/<skill>/_source/`,
+  `skills/web-automation/shared/`.
+- All 31 generated roots now carry `.generated-manifest.json` and file-type-aware
+  headers.
+- `package.json` renames: all generated agent-variant packages renamed to
+  `@ai-coding-skills/<skill>-<agent>` with `"private": true`.
+- `pnpm-workspace.yaml` updated: M1 negative-glob exclusions replaced by
+  positive includes for all uniquely-named generated variants.
+- Pre-existing ESLint violations fixed: `skill-manager-core.mjs:282`
+  (`no-useless-assignment`) and `manage-skills.mjs:270` (`no-unused-vars`).
+- Pre-existing shellcheck findings fixed: SC2034 and SC2329 in
+  `reviewer-runtime/run-review.sh`; SC2064 in test trap statements;
+  SC2016 / SC2251 in verify scripts (suppress intentional patterns).
+- `pnpm run sync:pi` now calls the generator instead of
+  `sync-pi-package-skills.sh`.
+- `docs/DEVELOPMENT.md` extended with generation workflow and metadata docs.
+- `CHANGELOG.md` created with package-metadata change callout.
+
+### Full byte-equivalence diff (M3 vs pre-M3)
+
+See `CHANGELOG.md` § "Byte-equivalence diff allow-list" for the complete
+documented diff between M3-generated output and the pre-M3 variants.  The
+only permitted diffs are headers, `.generated-manifest.json`, `name` rename,
+and `"private": true`.
+
+---
+
 ## Post-M2 state

 Captured: 2026-05-03 · Platform: macOS 15 (arm64) · Node 22.14.0 · pnpm 10.18.1