Files
ai-coding-skills/skills/reviewer-runtime/tests/claude-review-template-guard.sh
T
stefano 251148c3ff
check / check (ubuntu-latest) (push) Successful in 2m5s
check / check (macos-latest) (push) Has been cancelled
check-online / check-online (ubuntu-latest) (push) Successful in 1m53s
Perform code optimization and document cleanup (#1)
## Summary
- add repository-wide quality tooling and verification scaffolding, including CI workflows, pnpm workspace setup, ESLint/Prettier/markdown checks, and generated-output verification helpers
- reorganize skill sources and generation flow by introducing canonical `_source` variants, generator/manifests, reusable helper abstractions, and shared web-automation/browser utilities
- clean up and expand documentation so the root README flows into docs and skill docs, with clearer development, reviewer, installer, and workflow guidance

## Notable changes
- docs flow and consistency cleanup across `README.md`, `docs/README.md`, and related docs
- new scripts for `check`, docs verification, generated-file verification, shell portability, and safe directory replacement
- refactors in Atlassian and web-automation skill runtimes to reduce duplication and centralize reusable code
- changelog, development documentation, and CI surface updates

## Test Plan
- [ ] `pnpm run check`
- [ ] review generated/manifests and skill sync outputs
- [ ] smoke-check docs flow from `README.md` to `docs/README.md` to skill docs

## Notes
- this branch currently includes tracked `skills/web-automation/shared/node_modules` content that should be reviewed carefully as potentially noisy/accidental committed artifacts

Co-authored-by: Stefano Fiorini <stefano.fiorini@firsthorizon.com>
Reviewed-on: #1
2026-05-04 04:41:34 +00:00

55 lines
1.7 KiB
Bash
Executable File

#!/usr/bin/env bash
set -euo pipefail
SCRIPT_DIR=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)
REPO_ROOT=$(cd "$SCRIPT_DIR/../../.." && pwd)
fail() {
echo "FAIL: $*" >&2
exit 1
}
assert_contains() {
local file=$1
local pattern=$2
if ! grep -qF -- "$pattern" "$file"; then
fail "expected '$pattern' in $file"
fi
}
assert_not_contains() {
local file=$1
local pattern=$2
if grep -qF -- "$pattern" "$file"; then
fail "did not expect '$pattern' in $file"
fi
}
check_skill_file() {
local file=$1
assert_contains "$file" "claude -p \\"
# shellcheck disable=SC2016
assert_contains "$file" '$(cat /tmp/'
assert_contains "$file" "--strict-mcp-config"
assert_contains "$file" "--setting-sources user"
assert_contains "$file" "### P0"
assert_contains "$file" "In progress N"
assert_contains "$file" "notify-telegram.sh"
assert_contains "$file" "Before stopping for any user interaction, approval, or manual decision, send a Telegram summary first if configured."
assert_not_contains "$file" "--allowedTools Read"
}
check_skill_file "$REPO_ROOT/skills/implement-plan/claude-code/SKILL.md"
check_skill_file "$REPO_ROOT/skills/implement-plan/codex/SKILL.md"
check_skill_file "$REPO_ROOT/skills/implement-plan/cursor/SKILL.md"
check_skill_file "$REPO_ROOT/skills/implement-plan/opencode/SKILL.md"
check_skill_file "$REPO_ROOT/skills/create-plan/claude-code/SKILL.md"
check_skill_file "$REPO_ROOT/skills/create-plan/codex/SKILL.md"
check_skill_file "$REPO_ROOT/skills/create-plan/cursor/SKILL.md"
check_skill_file "$REPO_ROOT/skills/create-plan/opencode/SKILL.md"
echo "PASS: Claude reviewer templates use isolated settings and avoid Read-tool review prompts"