fix: make property-assessor safer for whatsapp runs
This commit is contained in:
@@ -7,6 +7,7 @@ import {
|
||||
dismissCommonOverlays,
|
||||
fail,
|
||||
gotoListing,
|
||||
runWithOperationTimeout,
|
||||
sleep,
|
||||
} from "./real-estate-photo-common.js";
|
||||
import { parseAddressIdentity, scoreAddressCandidate } from "./real-estate-address.js";
|
||||
@@ -64,63 +65,69 @@ export async function discoverHarListing(rawAddress) {
|
||||
const identity = parseAddressIdentity(address);
|
||||
const searchUrl = buildSearchUrl(address);
|
||||
const { context, page } = await createPageSession({ headless: process.env.HEADLESS !== "false" });
|
||||
const closeContext = async () => {
|
||||
await context.close().catch(() => {});
|
||||
};
|
||||
|
||||
try {
|
||||
const attempts = [`Opened HAR search URL: ${searchUrl}`];
|
||||
await gotoListing(page, searchUrl, 2500);
|
||||
await dismissCommonOverlays(page);
|
||||
await sleep(1500);
|
||||
return await runWithOperationTimeout(
|
||||
"HAR discovery",
|
||||
async () => {
|
||||
const attempts = [`Opened HAR search URL: ${searchUrl}`];
|
||||
await gotoListing(page, searchUrl, 2500);
|
||||
await dismissCommonOverlays(page);
|
||||
await sleep(1500);
|
||||
|
||||
let listingUrl = null;
|
||||
if (page.url().includes("/homedetail/")) {
|
||||
const directScore = scoreAddressCandidate(
|
||||
identity,
|
||||
`${page.url()} ${(await page.title()) || ""}`
|
||||
);
|
||||
if (directScore.matched) {
|
||||
listingUrl = normalizeListingUrl(page.url());
|
||||
attempts.push("HAR search URL resolved directly to a matching property page.");
|
||||
} else {
|
||||
attempts.push("HAR redirected to a property page, but it did not match the requested address closely enough.");
|
||||
}
|
||||
} else {
|
||||
const discovered = await collectListingUrl(page);
|
||||
const scored = discovered
|
||||
.map((candidate) => {
|
||||
const match = scoreAddressCandidate(
|
||||
let listingUrl = null;
|
||||
if (page.url().includes("/homedetail/")) {
|
||||
const directScore = scoreAddressCandidate(
|
||||
identity,
|
||||
`${candidate.url} ${candidate.text} ${candidate.parentText}`
|
||||
`${page.url()} ${(await page.title()) || ""}`
|
||||
);
|
||||
return { ...candidate, match };
|
||||
})
|
||||
.sort((a, b) => b.match.score - a.match.score);
|
||||
if (directScore.matched) {
|
||||
listingUrl = normalizeListingUrl(page.url());
|
||||
attempts.push("HAR search URL resolved directly to a matching property page.");
|
||||
} else {
|
||||
attempts.push("HAR redirected to a property page, but it did not match the requested address closely enough.");
|
||||
}
|
||||
} else {
|
||||
const discovered = await collectListingUrl(page);
|
||||
const scored = discovered
|
||||
.map((candidate) => {
|
||||
const match = scoreAddressCandidate(
|
||||
identity,
|
||||
`${candidate.url} ${candidate.text} ${candidate.parentText}`
|
||||
);
|
||||
return { ...candidate, match };
|
||||
})
|
||||
.sort((a, b) => b.match.score - a.match.score);
|
||||
|
||||
if (scored[0]?.match.matched) {
|
||||
listingUrl = normalizeListingUrl(scored[0].url);
|
||||
attempts.push(`HAR search results exposed a matching homedetail link with score ${scored[0].match.score}.`);
|
||||
} else {
|
||||
attempts.push("HAR discovery did not expose a confident homedetail match for this address.");
|
||||
if (scored[0]?.match.matched) {
|
||||
listingUrl = normalizeListingUrl(scored[0].url);
|
||||
attempts.push(`HAR search results exposed a matching homedetail link with score ${scored[0].match.score}.`);
|
||||
} else {
|
||||
attempts.push("HAR discovery did not expose a confident homedetail match for this address.");
|
||||
}
|
||||
}
|
||||
|
||||
return {
|
||||
source: "har",
|
||||
address,
|
||||
searchUrl,
|
||||
finalUrl: page.url(),
|
||||
title: await page.title(),
|
||||
listingUrl,
|
||||
attempts,
|
||||
};
|
||||
},
|
||||
{
|
||||
onTimeout: closeContext
|
||||
}
|
||||
}
|
||||
|
||||
const result = {
|
||||
source: "har",
|
||||
address,
|
||||
searchUrl,
|
||||
finalUrl: page.url(),
|
||||
title: await page.title(),
|
||||
listingUrl,
|
||||
attempts,
|
||||
};
|
||||
await context.close();
|
||||
return result;
|
||||
);
|
||||
} catch (error) {
|
||||
try {
|
||||
await context.close();
|
||||
} catch {
|
||||
// Ignore close errors after the primary failure.
|
||||
}
|
||||
throw new Error(`HAR discovery failed: ${error instanceof Error ? error.message : String(error)}`);
|
||||
} finally {
|
||||
await closeContext();
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user