feat(S-302): Test-drive and implement job lifecycle subcommands
This commit is contained in:
@@ -888,4 +888,544 @@ describe("main", () => {
|
||||
out.restore();
|
||||
}
|
||||
});
|
||||
|
||||
// Job lifecycle subcommands (S-302)
|
||||
|
||||
it("start starts job and returns job ID JSON", async () => {
|
||||
const out = captureOutput();
|
||||
try {
|
||||
const started: { client: ClientName; prompt: string; options?: any }[] = [];
|
||||
const code = await main(
|
||||
["node", "cli.ts", "start", "--client", "codex", "--prompt", "hello"],
|
||||
{
|
||||
detectClients: () => mockClients,
|
||||
startJob: async (client, prompt, options) => {
|
||||
started.push({ client, prompt, options });
|
||||
return { id: "job-start-1", client, prompt, status: "running", startedAt: new Date().toISOString() };
|
||||
},
|
||||
}
|
||||
);
|
||||
assert.strictEqual(code, 0);
|
||||
assert.strictEqual(started.length, 1);
|
||||
assert.strictEqual(started[0].client, "codex");
|
||||
assert.strictEqual(started[0].prompt, "hello");
|
||||
const parsed = JSON.parse(out.logs[0]);
|
||||
assert.strictEqual(parsed.jobId, "job-start-1");
|
||||
assert.strictEqual(parsed.client, "codex");
|
||||
assert.strictEqual(parsed.status, "running");
|
||||
} finally {
|
||||
out.restore();
|
||||
}
|
||||
});
|
||||
|
||||
it("start returns 1 when client is missing", async () => {
|
||||
const out = captureOutput();
|
||||
try {
|
||||
const code = await main(["node", "cli.ts", "start", "--prompt", "hello"], {
|
||||
detectClients: () => mockClients,
|
||||
});
|
||||
assert.strictEqual(code, 1);
|
||||
const parsed = JSON.parse(out.errors[0]);
|
||||
assert.ok(parsed.error.includes("client"));
|
||||
} finally {
|
||||
out.restore();
|
||||
}
|
||||
});
|
||||
|
||||
it("start returns 1 when prompt is missing", async () => {
|
||||
const out = captureOutput();
|
||||
try {
|
||||
const code = await main(["node", "cli.ts", "start", "--client", "codex"], {
|
||||
detectClients: () => mockClients,
|
||||
});
|
||||
assert.strictEqual(code, 1);
|
||||
const parsed = JSON.parse(out.errors[0]);
|
||||
assert.ok(parsed.error.includes("prompt"));
|
||||
} finally {
|
||||
out.restore();
|
||||
}
|
||||
});
|
||||
|
||||
it("status <job-id> returns running job JSON", async () => {
|
||||
const out = captureOutput();
|
||||
try {
|
||||
const code = await main(
|
||||
["node", "cli.ts", "status", "job-123"],
|
||||
{
|
||||
detectClients: () => mockClients,
|
||||
getJob: (jobId) => ({
|
||||
id: jobId,
|
||||
client: "codex",
|
||||
prompt: "hello",
|
||||
status: "running",
|
||||
startedAt: "2024-01-01T00:00:00Z",
|
||||
} as any),
|
||||
}
|
||||
);
|
||||
assert.strictEqual(code, 0);
|
||||
const parsed = JSON.parse(out.logs[0]);
|
||||
assert.strictEqual(parsed.id, "job-123");
|
||||
assert.strictEqual(parsed.status, "running");
|
||||
assert.strictEqual(parsed.client, "codex");
|
||||
} finally {
|
||||
out.restore();
|
||||
}
|
||||
});
|
||||
|
||||
it("status <job-id> returns completed job JSON", async () => {
|
||||
const out = captureOutput();
|
||||
try {
|
||||
const code = await main(
|
||||
["node", "cli.ts", "status", "job-456"],
|
||||
{
|
||||
detectClients: () => mockClients,
|
||||
getJob: (jobId) => ({
|
||||
id: jobId,
|
||||
client: "claude",
|
||||
prompt: "write tests",
|
||||
status: "completed",
|
||||
startedAt: "2024-01-01T00:00:00Z",
|
||||
completedAt: "2024-01-01T00:01:00Z",
|
||||
result: { stdout: "ok", stderr: "", exitCode: 0, client: "claude", durationMs: 100 },
|
||||
} as any),
|
||||
}
|
||||
);
|
||||
assert.strictEqual(code, 0);
|
||||
const parsed = JSON.parse(out.logs[0]);
|
||||
assert.strictEqual(parsed.status, "completed");
|
||||
assert.strictEqual(parsed.result.exitCode, 0);
|
||||
} finally {
|
||||
out.restore();
|
||||
}
|
||||
});
|
||||
|
||||
it("status returns 1 and prints error JSON for nonexistent job", async () => {
|
||||
const out = captureOutput();
|
||||
try {
|
||||
const code = await main(
|
||||
["node", "cli.ts", "status", "missing-job"],
|
||||
{
|
||||
detectClients: () => mockClients,
|
||||
getJob: () => {
|
||||
throw new Error('Job "missing-job" not found.');
|
||||
},
|
||||
}
|
||||
);
|
||||
assert.strictEqual(code, 1);
|
||||
const parsed = JSON.parse(out.errors[0]);
|
||||
assert.ok(parsed.error.includes("not found"));
|
||||
} finally {
|
||||
out.restore();
|
||||
}
|
||||
});
|
||||
|
||||
it("status returns 1 when job-id is missing", async () => {
|
||||
const out = captureOutput();
|
||||
try {
|
||||
const code = await main(["node", "cli.ts", "status"], {
|
||||
detectClients: () => mockClients,
|
||||
});
|
||||
assert.strictEqual(code, 1);
|
||||
const parsed = JSON.parse(out.errors[0]);
|
||||
assert.ok(parsed.error.includes("job-id"));
|
||||
} finally {
|
||||
out.restore();
|
||||
}
|
||||
});
|
||||
|
||||
it("status prints text output with --text", async () => {
|
||||
const out = captureOutput();
|
||||
try {
|
||||
const code = await main(
|
||||
["node", "cli.ts", "status", "job-123", "--text"],
|
||||
{
|
||||
detectClients: () => mockClients,
|
||||
getJob: (jobId) => ({
|
||||
id: jobId,
|
||||
client: "codex",
|
||||
prompt: "hello",
|
||||
status: "running",
|
||||
startedAt: "2024-01-01T00:00:00Z",
|
||||
} as any),
|
||||
}
|
||||
);
|
||||
assert.strictEqual(code, 0);
|
||||
assert.ok(out.logs[0].includes("running"));
|
||||
assert.ok(out.logs[0].includes("job-123"));
|
||||
} finally {
|
||||
out.restore();
|
||||
}
|
||||
});
|
||||
|
||||
it("results <job-id> returns ExecResult JSON for completed job", async () => {
|
||||
const out = captureOutput();
|
||||
try {
|
||||
const code = await main(
|
||||
["node", "cli.ts", "results", "job-789"],
|
||||
{
|
||||
detectClients: () => mockClients,
|
||||
getJobResult: () => ({
|
||||
stdout: "output",
|
||||
stderr: "",
|
||||
exitCode: 0,
|
||||
client: "codex",
|
||||
durationMs: 42,
|
||||
}),
|
||||
}
|
||||
);
|
||||
assert.strictEqual(code, 0);
|
||||
const parsed = JSON.parse(out.logs[0]);
|
||||
assert.strictEqual(parsed.stdout, "output");
|
||||
assert.strictEqual(parsed.exitCode, 0);
|
||||
} finally {
|
||||
out.restore();
|
||||
}
|
||||
});
|
||||
|
||||
it("results returns 1 and prints error JSON for still-running job", async () => {
|
||||
const out = captureOutput();
|
||||
try {
|
||||
const code = await main(
|
||||
["node", "cli.ts", "results", "job-running"],
|
||||
{
|
||||
detectClients: () => mockClients,
|
||||
getJobResult: () => {
|
||||
throw new Error('Job "job-running" result is not available (status: running).');
|
||||
},
|
||||
}
|
||||
);
|
||||
assert.strictEqual(code, 1);
|
||||
const parsed = JSON.parse(out.errors[0]);
|
||||
assert.ok(parsed.error.includes("not available"));
|
||||
} finally {
|
||||
out.restore();
|
||||
}
|
||||
});
|
||||
|
||||
it("results returns 1 and prints error JSON for nonexistent job", async () => {
|
||||
const out = captureOutput();
|
||||
try {
|
||||
const code = await main(
|
||||
["node", "cli.ts", "results", "missing-job"],
|
||||
{
|
||||
detectClients: () => mockClients,
|
||||
getJobResult: () => {
|
||||
throw new Error('Job "missing-job" not found.');
|
||||
},
|
||||
}
|
||||
);
|
||||
assert.strictEqual(code, 1);
|
||||
const parsed = JSON.parse(out.errors[0]);
|
||||
assert.ok(parsed.error.includes("not found"));
|
||||
} finally {
|
||||
out.restore();
|
||||
}
|
||||
});
|
||||
|
||||
it("results returns 1 when job-id is missing", async () => {
|
||||
const out = captureOutput();
|
||||
try {
|
||||
const code = await main(["node", "cli.ts", "results"], {
|
||||
detectClients: () => mockClients,
|
||||
});
|
||||
assert.strictEqual(code, 1);
|
||||
const parsed = JSON.parse(out.errors[0]);
|
||||
assert.ok(parsed.error.includes("job-id"));
|
||||
} finally {
|
||||
out.restore();
|
||||
}
|
||||
});
|
||||
|
||||
it("results prints text output with --text", async () => {
|
||||
const out = captureOutput();
|
||||
const stdoutChunks: string[] = [];
|
||||
try {
|
||||
const code = await main(
|
||||
["node", "cli.ts", "results", "job-789", "--text"],
|
||||
{
|
||||
detectClients: () => mockClients,
|
||||
getJobResult: () => ({
|
||||
stdout: "hello-out",
|
||||
stderr: "hello-err",
|
||||
exitCode: 0,
|
||||
client: "codex",
|
||||
durationMs: 42,
|
||||
}),
|
||||
stdoutWrite: (chunk) => stdoutChunks.push(chunk),
|
||||
}
|
||||
);
|
||||
assert.strictEqual(code, 0);
|
||||
assert.strictEqual(stdoutChunks.join(""), "hello-out");
|
||||
} finally {
|
||||
out.restore();
|
||||
}
|
||||
});
|
||||
|
||||
it("cancel <job-id> returns cancelled confirmation for running job", async () => {
|
||||
const out = captureOutput();
|
||||
try {
|
||||
let cancelledJobId: string | undefined;
|
||||
const code = await main(
|
||||
["node", "cli.ts", "cancel", "job-abc"],
|
||||
{
|
||||
detectClients: () => mockClients,
|
||||
getJob: (jobId) => ({
|
||||
id: jobId,
|
||||
client: "codex",
|
||||
prompt: "hello",
|
||||
status: "running",
|
||||
startedAt: "2024-01-01T00:00:00Z",
|
||||
} as any),
|
||||
cancelJob: (jobId) => {
|
||||
cancelledJobId = jobId;
|
||||
},
|
||||
}
|
||||
);
|
||||
assert.strictEqual(code, 0);
|
||||
assert.strictEqual(cancelledJobId, "job-abc");
|
||||
const parsed = JSON.parse(out.logs[0]);
|
||||
assert.strictEqual(parsed.jobId, "job-abc");
|
||||
assert.strictEqual(parsed.cancelled, true);
|
||||
} finally {
|
||||
out.restore();
|
||||
}
|
||||
});
|
||||
|
||||
it("cancel returns 1 and prints error JSON for completed job", async () => {
|
||||
const out = captureOutput();
|
||||
try {
|
||||
const code = await main(
|
||||
["node", "cli.ts", "cancel", "job-done"],
|
||||
{
|
||||
detectClients: () => mockClients,
|
||||
getJob: (jobId) => ({
|
||||
id: jobId,
|
||||
client: "codex",
|
||||
prompt: "hello",
|
||||
status: "completed",
|
||||
startedAt: "2024-01-01T00:00:00Z",
|
||||
completedAt: "2024-01-01T00:01:00Z",
|
||||
} as any),
|
||||
}
|
||||
);
|
||||
assert.strictEqual(code, 1);
|
||||
const parsed = JSON.parse(out.errors[0]);
|
||||
assert.ok(parsed.error.includes("running"));
|
||||
} finally {
|
||||
out.restore();
|
||||
}
|
||||
});
|
||||
|
||||
it("cancel returns 1 and prints error JSON for nonexistent job", async () => {
|
||||
const out = captureOutput();
|
||||
try {
|
||||
const code = await main(
|
||||
["node", "cli.ts", "cancel", "missing-job"],
|
||||
{
|
||||
detectClients: () => mockClients,
|
||||
getJob: () => {
|
||||
throw new Error('Job "missing-job" not found.');
|
||||
},
|
||||
}
|
||||
);
|
||||
assert.strictEqual(code, 1);
|
||||
const parsed = JSON.parse(out.errors[0]);
|
||||
assert.ok(parsed.error.includes("not found"));
|
||||
} finally {
|
||||
out.restore();
|
||||
}
|
||||
});
|
||||
|
||||
it("cancel returns 1 when job-id is missing", async () => {
|
||||
const out = captureOutput();
|
||||
try {
|
||||
const code = await main(["node", "cli.ts", "cancel"], {
|
||||
detectClients: () => mockClients,
|
||||
});
|
||||
assert.strictEqual(code, 1);
|
||||
const parsed = JSON.parse(out.errors[0]);
|
||||
assert.ok(parsed.error.includes("job-id"));
|
||||
} finally {
|
||||
out.restore();
|
||||
}
|
||||
});
|
||||
|
||||
it("cancel prints text output with --text", async () => {
|
||||
const out = captureOutput();
|
||||
try {
|
||||
const code = await main(
|
||||
["node", "cli.ts", "cancel", "job-abc", "--text"],
|
||||
{
|
||||
detectClients: () => mockClients,
|
||||
getJob: (jobId) => ({
|
||||
id: jobId,
|
||||
client: "codex",
|
||||
prompt: "hello",
|
||||
status: "running",
|
||||
startedAt: "2024-01-01T00:00:00Z",
|
||||
} as any),
|
||||
cancelJob: () => {},
|
||||
}
|
||||
);
|
||||
assert.strictEqual(code, 0);
|
||||
assert.ok(out.logs[0].includes("cancelled"));
|
||||
assert.ok(out.logs[0].includes("job-abc"));
|
||||
} finally {
|
||||
out.restore();
|
||||
}
|
||||
});
|
||||
|
||||
it("list-jobs returns array of all jobs", async () => {
|
||||
const out = captureOutput();
|
||||
try {
|
||||
const code = await main(
|
||||
["node", "cli.ts", "list-jobs"],
|
||||
{
|
||||
detectClients: () => mockClients,
|
||||
listJobs: () => [
|
||||
{ id: "job-1", client: "codex", prompt: "p1", status: "running", startedAt: "2024-01-01T00:00:00Z" },
|
||||
{ id: "job-2", client: "claude", prompt: "p2", status: "completed", startedAt: "2024-01-01T00:01:00Z" },
|
||||
] as any[],
|
||||
}
|
||||
);
|
||||
assert.strictEqual(code, 0);
|
||||
const parsed = JSON.parse(out.logs[0]);
|
||||
assert.strictEqual(parsed.length, 2);
|
||||
assert.strictEqual(parsed[0].id, "job-1");
|
||||
assert.strictEqual(parsed[1].id, "job-2");
|
||||
} finally {
|
||||
out.restore();
|
||||
}
|
||||
});
|
||||
|
||||
it("list-jobs filters by --status", async () => {
|
||||
const out = captureOutput();
|
||||
try {
|
||||
let receivedFilter: string | undefined;
|
||||
const code = await main(
|
||||
["node", "cli.ts", "list-jobs", "--status", "running"],
|
||||
{
|
||||
detectClients: () => mockClients,
|
||||
listJobs: (options) => {
|
||||
receivedFilter = options?.filter;
|
||||
return [
|
||||
{ id: "job-1", client: "codex", prompt: "p1", status: "running", startedAt: "2024-01-01T00:00:00Z" },
|
||||
] as any[];
|
||||
},
|
||||
}
|
||||
);
|
||||
assert.strictEqual(code, 0);
|
||||
assert.strictEqual(receivedFilter, "running");
|
||||
const parsed = JSON.parse(out.logs[0]);
|
||||
assert.strictEqual(parsed.length, 1);
|
||||
assert.strictEqual(parsed[0].status, "running");
|
||||
} finally {
|
||||
out.restore();
|
||||
}
|
||||
});
|
||||
|
||||
it("list-jobs prints text output with --text", async () => {
|
||||
const out = captureOutput();
|
||||
try {
|
||||
const code = await main(
|
||||
["node", "cli.ts", "list-jobs", "--text"],
|
||||
{
|
||||
detectClients: () => mockClients,
|
||||
listJobs: () => [
|
||||
{ id: "job-1", client: "codex", prompt: "p1", status: "running", startedAt: "2024-01-01T00:00:00Z" },
|
||||
] as any[],
|
||||
}
|
||||
);
|
||||
assert.strictEqual(code, 0);
|
||||
assert.ok(out.logs[0].includes("job-1"));
|
||||
assert.ok(out.logs[0].includes("codex"));
|
||||
assert.ok(out.logs[0].includes("running"));
|
||||
} finally {
|
||||
out.restore();
|
||||
}
|
||||
});
|
||||
|
||||
it("cleanup-jobs returns count of cleaned jobs", async () => {
|
||||
const out = captureOutput();
|
||||
try {
|
||||
let callCount = 0;
|
||||
const jobs = [
|
||||
{ id: "job-1", client: "codex", prompt: "p1", status: "completed", startedAt: "2024-01-01T00:00:00Z" },
|
||||
{ id: "job-2", client: "claude", prompt: "p2", status: "completed", startedAt: "2024-01-01T00:01:00Z" },
|
||||
];
|
||||
const code = await main(
|
||||
["node", "cli.ts", "cleanup-jobs"],
|
||||
{
|
||||
detectClients: () => mockClients,
|
||||
listJobs: () => {
|
||||
callCount++;
|
||||
return callCount === 1 ? jobs : [];
|
||||
},
|
||||
cleanupJobs: () => {},
|
||||
}
|
||||
);
|
||||
assert.strictEqual(code, 0);
|
||||
const parsed = JSON.parse(out.logs[0]);
|
||||
assert.strictEqual(parsed.count, 2);
|
||||
} finally {
|
||||
out.restore();
|
||||
}
|
||||
});
|
||||
|
||||
it("cleanup-jobs with --max-age parses hours", async () => {
|
||||
const out = captureOutput();
|
||||
try {
|
||||
let receivedMaxAgeMs: number | undefined;
|
||||
const code = await main(
|
||||
["node", "cli.ts", "cleanup-jobs", "--max-age", "12h"],
|
||||
{
|
||||
detectClients: () => mockClients,
|
||||
listJobs: () => [],
|
||||
cleanupJobs: (options) => {
|
||||
receivedMaxAgeMs = options?.maxAgeMs;
|
||||
},
|
||||
}
|
||||
);
|
||||
assert.strictEqual(code, 0);
|
||||
assert.strictEqual(receivedMaxAgeMs, 12 * 60 * 60 * 1000);
|
||||
} finally {
|
||||
out.restore();
|
||||
}
|
||||
});
|
||||
|
||||
it("cleanup-jobs returns 1 for invalid --max-age format", async () => {
|
||||
const out = captureOutput();
|
||||
try {
|
||||
const code = await main(
|
||||
["node", "cli.ts", "cleanup-jobs", "--max-age", "abc"],
|
||||
{
|
||||
detectClients: () => mockClients,
|
||||
}
|
||||
);
|
||||
assert.strictEqual(code, 1);
|
||||
const parsed = JSON.parse(out.errors[0]);
|
||||
assert.ok(parsed.error.includes("max-age"));
|
||||
} finally {
|
||||
out.restore();
|
||||
}
|
||||
});
|
||||
|
||||
it("cleanup-jobs prints text output with --text", async () => {
|
||||
const out = captureOutput();
|
||||
try {
|
||||
const code = await main(
|
||||
["node", "cli.ts", "cleanup-jobs", "--text"],
|
||||
{
|
||||
detectClients: () => mockClients,
|
||||
listJobs: () => [],
|
||||
cleanupJobs: () => {},
|
||||
}
|
||||
);
|
||||
assert.strictEqual(code, 0);
|
||||
assert.ok(out.logs[0].includes("Cleaned"));
|
||||
assert.ok(out.logs[0].includes("0"));
|
||||
} finally {
|
||||
out.restore();
|
||||
}
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user